Braided Brake Line failure?

[Adam2201]

Yeah, the arrow is pointing forwards, and the tabs at the end of the spring are supposed to be touching the caliper body aren't they? I mean, they don't engage with the pad? I just can't understand why one side has no movement at all, but the other side clatters against the caliper when they are both fitted the same way.  I must be doing something wrong!